[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 18 14:06:00 PDT 2023


================
@@ -2219,7 +2219,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
   const FileSpec &file = m_file ? m_file : module_sp->GetFileSpec();
   const char *file_name = file.GetFilename().AsCString("<Unknown>");
   LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
-  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name));
+  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name), UINT64_MAX, nullptr, true);
----------------
medismailben wrote:

It's a bit unfortunate that you have to specify all the other default parameters to set `is_discret` to true ... may be it would be worth to make the first default argument so you can omit the 2 others default arguments ?

https://github.com/llvm/llvm-project/pull/69516


More information about the lldb-commits mailing list