[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 13 08:20:39 PDT 2023


github-actions[bot] wrote:


<!--LLVM CODE FORMAT COMMENT: {clang-format}-->

:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff ba79fb2e1ff7130cde02fbbd325f0f96f8a522ca 819c92f8793a0547293e419be9394559add46564 -- lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
index 03cc4b41661c..f970d3ef053b 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
@@ -168,10 +168,9 @@ lldb::ValueObjectSP lldb_private::formatters::
 
       value_sp = node_sp->GetChildMemberWithName("__value_");
       if (!value_sp) {
-        // Since D101206 (ba79fb2e1f), libc++ wraps the `__value_` in an anonymous union.
-        // Child 0: __hash_node_base base class
-        // Child 1: __hash_
-        // Child 2: anonymous union
+        // Since D101206 (ba79fb2e1f), libc++ wraps the `__value_` in an
+        // anonymous union. Child 0: __hash_node_base base class Child 1:
+        // __hash_ Child 2: anonymous union
         auto anon_union_sp = node_sp->GetChildAtIndex(2);
         if (!anon_union_sp)
           return nullptr;

``````````

</details>


https://github.com/llvm/llvm-project/pull/68574


More information about the lldb-commits mailing list