[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

Tom Yang via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 11 15:39:59 PDT 2023


================
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream &strm, Module *module) {
   return false;
 }
 
+static bool GetSeparateDebugInfoList(StructuredData::Array &list,
+                                     Module *module) {
+  if (module) {
+    if (SymbolFile *symbol_file = module->GetSymbolFile(true)) {
----------------
zhyty wrote:

That's not valid syntax, and I'm not sure how to use a single `if` statement to capture the meaning. I could write by declaring `symbol_file` outside of the `if` statement condition, but I think that's unnecessarily verbose. Besides, 10 lines up we do the same thing.

https://github.com/llvm/llvm-project/pull/66035


More information about the lldb-commits mailing list