[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)
Pete Lawrence via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 10 01:53:23 PDT 2023
================
@@ -173,7 +173,16 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
ExpressionResults expr_result =
- target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_options);
+ target.EvaluateExpression(expr, exe_scope, valobj_sp, eval_options, &m_fixed_expression);
+
+ // Only mention Fix-Its if the command applies them.
+ // The compiler errors can address any parsing issues after applying Fix-It(s).
+ if (!m_fixed_expression.empty() && target.GetEnableNotifyAboutFixIts()) {
+ Stream &error_stream = result.GetErrorStream();
+ error_stream.Printf(" Applying Fix-It to expression, changing it to:\n %s\n",
----------------
PortalPete wrote:
Changed phrasing to past tense because this message appears after the expression's result.
```cpp
error_stream << " Evaluated this expression after applying Fix-It(s):\n";
error_stream << " " << fixed_expression << "\n";
```
https://github.com/llvm/llvm-project/pull/68452
More information about the lldb-commits
mailing list