[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 6 16:20:58 PDT 2023


================
@@ -43,6 +43,10 @@ class CommandObjectDWIMPrint : public CommandObjectRaw {
   HandleArgumentCompletion(CompletionRequest &request,
                            OptionElementVector &opt_element_vector) override;
 
+protected:
+  /// Stores the expression after applying any Fix-Its.
+  std::string m_fixed_expression;
----------------
kastiglione wrote:

Yes I noticed that expression needs it to be a member variable. Personally I'd prefer to see this class be slightly different (it is already, anyway), than copy what expression does. It's good to keep them consistent, but it's better, imo, to avoid introducing bits of unnecessary complexity.

https://github.com/llvm/llvm-project/pull/68452


More information about the lldb-commits mailing list