[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

[Jonas Devlieghere via lldb-commits]

================
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) {
   });
 }
 
+SBProcess SBPlatform::Attach(SBAttachInfo &attach_info,
+                             const SBDebugger &debugger, SBTarget &target,
----------------
JDevlieghere wrote:

- `attach_info` cannot be const because `Platform::Attach` also takes a non-cost `AttachInfo`. There's at least one place (`PlatformPOSIX::Attach`) that modifies the `attach_info`. 
- `target` is an out parameter so making that const would be confusing. 

https://github.com/llvm/llvm-project/pull/68050