[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 2 17:00:04 PDT 2023


================
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) {
   });
 }
 
+SBProcess SBPlatform::Attach(SBAttachInfo &attach_info,
+                             const SBDebugger &debugger, SBTarget &target,
----------------
bulbazord wrote:

I'd like to see the `attach_info` parameter marked const if possible, but it looks like `SBAttachInfo::ref` is not const. Maybe we can add an overload?

I think that you can do `const SBTarget &target` without any further changes because `SBTarget::GetSP` is marked `const`.

https://github.com/llvm/llvm-project/pull/68050


More information about the lldb-commits mailing list