[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

Ah, I see the bug where `watch set expression` ends up marked as `rw`.  CommandObjectWatchpointSetExpression::DoExecute passes `OptionGroupWatchpoint::eWatchModify` as the type to Target::CreateWatchpoint (which takes that as a uint32_t).  It passes that `uint32_t kind` to Watchpoint::SetWatchpointType which is expecting the `uint32_t kind` to be a bitfield with `LLDB_WATCH_TYPE_{READ,WRITE,MODIFY}`.  `OptionGroupWatchpoint::eWatchModify` had value 3, so we get bits 1 and 2 set here, which is `rw`.  lol.

https://github.com/llvm/llvm-project/pull/66308