[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

[David Spickett via lldb-commits]

DavidSpickett wrote:

I've updated the tests and relanded but there is still some stuff to check. The tagged address test is working fine but the default watchpoint type is different between the 2 commands, which seems wrong at first glance.

For the other one see https://github.com/llvm/llvm-project/issues/26405 for some context. I guess somewhere we need to check for a read/write or modify break on the location before allowing the user to set another one, since that's where the test used to fail when it tried to place the second watchpoint. Since the globals are all chars and their addresses when aligned down were the same, I think. See if you can figure that one out.

https://github.com/llvm/llvm-project/pull/66308