[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

This looks good with just one nit above.



================
Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:74
 
-  if (m_register_info_up->IsSVEEnabled())
+  if (m_register_info_up->IsSSVEEnabled()) {
+    m_sve_data = getRegset(notes, target_triple, AARCH64_SSVE_Desc);
----------------
 if (m_sve_data.GetByteSize() >= sizeof(sve::user_sve_header)) {
below seems redundant because IsSSVEEnabled returns true when
```
  if (ssve_data.GetByteSize() >= sizeof(sve::user_sve_header))
    opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskSSVE);
```
has set it enabled. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158500/new/

https://reviews.llvm.org/D158500