[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 20 13:42:43 PDT 2023


jimingham wrote:

In this case, it's clearly not a regex, so this change is fine.  But ALSO, any regex matches against std types should be `^std::whatever` and not just `std::whatever` to avoid this sort of unintended matching.

Jim


> On Sep 20, 2023, at 1:37 PM, Walter Erquinigo ***@***.***> wrote:
> 
> 
> @walter-erquinigo approved this pull request.
> 
> Good catch! I think I have suffered because of this at some point.
> 
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/66949#pullrequestreview-1636465803>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVWY4RBH5JH3GUIU6IUTX3NHYFANCNFSM6AAAAAA5APBMII>.
> You are receiving this because your review was requested.
> 



https://github.com/llvm/llvm-project/pull/66949


More information about the lldb-commits mailing list