[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

Are



================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181
+
+  return {};
+}
----------------
Shouldnt we build a relevant error message here incase ReadSMEControl fails on ReadZAHeader


================
Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_save_restore/TestZARegisterSaveRestore.py:183
+            self.expect("register read svcr", substrs=["0x{:016x}".format(svcr_value)])
 
         for expr in exprs:
----------------
should we also add a svcr write test here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154927/new/

https://reviews.llvm.org/D154927