[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

[Greg Clayton via lldb-commits]

================
@@ -1326,23 +1326,35 @@ lldb::SBWatchpoint SBTarget::WatchAddress(lldb::addr_t addr, size_t size,
                                           SBError &error) {
   LLDB_INSTRUMENT_VA(this, addr, size, read, write, error);
 
+  SBWatchpointOptions options;
+  options.SetWatchpointTypeRead(read);
+  options.SetWatchpointTypeModify(write);
----------------
clayborg wrote:

do we want to rename this argument from "write" to "modify" to clarify what will happen? Variable names are not included in the mangled name, so we can rename as long as we don't change the type and not affect the API backwards compat. If we do rename, then update the header file as well

https://github.com/llvm/llvm-project/pull/66308