[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 15 09:26:22 PDT 2023
clayborg wrote:
> I think it would be easier to read the output if you made a separate column for "error". If you imagine a listing where there are 100 OSO's of which 10 are missing, the paths are going to jump over because of the "error: ..." at the beginning of those lines making it messy for your eyes to track. Seems like there are only two possible errors "file not found" and "file out of date", so it seems like we should be able to make a fairly short error column after the ID and then the path?
The errors are quite long as they mention the offending path to the OSO and the OSO paths are often very long, so you would need to run through the results to calculate the max width of the OSO path and then you would almost certainly overlflow off the right edge of the terminal if you also show the error string.
This patch currently doesn't show the OSO path if there is an error , so we show the error in place of the OSO path as the error string contains the path in the error text. Would your prefer to always show the modtime + oso path and then add the error on the next line?
https://github.com/llvm/llvm-project/pull/66035
More information about the lldb-commits
mailing list