[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added a comment.

> In this test can we figure out whether SVE was read from Streaming mode or normal SVE mode?? and if yes may be add a check for that.

Not sure what you mean.

If you mean:

- write non-streaming SVE with one set of values
- write streaming SVE with another
- assert that lldb read the correct one

There are a couple of issues there:

- If lldb read the inactive mode, it would fail with unavailable register due to a failure down in lldb-sever. These tests would already catch that.
- The kernel and the architecture say that the values of the registers for the mode you are coming from are wiped out on mode switch. So we wouldn't be able to truly read those values even if we were able to make the ptrace call and get some data.

So it's covered, but does not/ can not be covered by checking values. It'll be correct values, or a complete failure to read.



================
Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:156
+
+        register_sets = currentFrame.GetRegisters()
+
----------------
omjavaid wrote:
> can we use self.thread().GetSelectedFrame().GetRegisters() ?? or are you going to use target process thread and current frame variables in later patches?
No I just copied this from the original test, in fact later I wrap this all into a function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157846/new/

https://reviews.llvm.org/D157846