[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

Mon Sep 11 13:37:45 PDT 2023

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

I really dislike all the manual memory management that's going on in this file, but I realize that's not the result of this patch, but rather because of the code that was factored out. I'd love if someone would replace the mallo'c buffers with `SmallString<0>`s but that's orthogonal to this patch. LGTM.

================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:73
 #include <optional>
+#include <sstream>

----------------
I don't think this is needed (anymore)? 

================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:124
+  std::vector<std::tuple<lldb::offset_t, lldb::offset_t>>
+  FindLC_NOTEByName(std::string name);
+
----------------
Thanks for factoring this out!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158785/new/

https://reviews.llvm.org/D158785