[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 556327.
jasonmolenda added a comment.

All of the feedback is addressed at this point.  I had one decision I didn't like - the LC_NOTE has an explicit size in the load command, but I said that the JSON string needed to be nul byte ('\0') terminated, which is redundant.  I've changed the implementation to (1) in the producer size, don't add a nul byte at the end of the string, and (2) add the nul byte to the read buffer, before treating it as a c-string.  To help emphasize that the size of the LC_NOTE is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158785/new/

https://reviews.llvm.org/D158785

Files:
  lldb/include/lldb/Symbol/ObjectFile.h
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
  lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158785.556327.patch
Type: text/x-patch
Size: 37416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230909/8a64b43d/attachment-0001.bin>