[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1747-1754
     if (!comp_dir) {
       unit.SetDwoError(Status::createWithFormat(
           "unable to locate relative .dwo debug file \"{0}\" for "
           "skeleton DIE {1:x16} without valid DW_AT_comp_dir "
           "attribute",
           dwo_name, cu_die.GetOffset()));
       return nullptr;
----------------
If we have no comp_dir, then we should still search for the file right? We are returning early here without trying to use the search paths?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1779
+        FileSystem::Instance().Resolve(dirspec);
+        if (!FileSystem::Instance().IsDirectory(dirspec))
+          continue;
----------------
Will this return false for a symlink to a directory?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157609/new/

https://reviews.llvm.org/D157609