[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

[Mark de Wever via Phabricator via lldb-commits]

Mordante marked 4 inline comments as done.
Mordante added inline comments.


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:986-993
+      "^std::__[[:alnum:]]+::chrono::"
+      "(((nano)|(micro)|(milli)|())seconds)|"
+      "(minutes)|"
+      "(hours)|"
+      "(days)|"
+      "(weeks)|"
+      "(months)|"
----------------
kastiglione wrote:
> there's some regex grouping that doesn't seem to be needed.
Earlier testing without grouping didn't work. Since the next iteration uses units here is a regex per type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159127/new/

https://reviews.llvm.org/D159127