[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

Wed Aug 30 17:27:53 PDT 2023

bulbazord added a comment.

In D158833#4626023 <https://reviews.llvm.org/D158833#4626023>, @mib wrote:

> In D158833#4625775 <https://reviews.llvm.org/D158833#4625775>, @bulbazord wrote:
>
>> Re-organizing the paths seems okay to me, especially since this is going to grow further. I think the header guards are going to need some adjustment though.
>
> TBH, I didn't even know they were guidelines wrt header guards 😅
>
> For long file names, I've been using this pattern in the past of separating the words by `_` in the header guards, which also makes it more readable.
>
> I don't think that causes any harm but if you feel strongly about it I can change it.

I don't think it's a huge deal personally. If you look hard enough, LLDB (and probably LLVM) are full of tiny mistakes in the header guard from moving files around.

For reference, the LLVM coding standards talks about it here: https://llvm.org/docs/CodingStandards.html#header-guard

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158833/new/

https://reviews.llvm.org/D158833