[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Core/Section.cpp:153
+  case eSectionTypeSwiftModules:
+    return "swift-modules";
   }
----------------
compnerd wrote:
> kastiglione wrote:
> > I wonder if this should be "swiftmodules". I have never seen it spelled with a hyphen.
> Is it actually more than one module?  If not, `swift-module` would make sense given the DWARF cases - it is a "Swift Module" converted to lower kebab case.
I added a hyphen to match the previous section types, but I'm not tied to the naming scheme.
I don't know if there is more than one module, but the enum case is plural so I made the string plural too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159142/new/

https://reviews.llvm.org/D159142