[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 29 10:51:04 PDT 2023


bulbazord added a comment.

Re-organizing the paths seems okay to me, especially since this is going to grow further. I think the header guards are going to need some adjustment though.



================
Comment at: lldb/include/lldb/Interpreter/Interfaces/ScriptedProcessInterface.h:9
 
-#ifndef LLDB_INTERPRETER_SCRIPTEDPROCESSINTERFACE_H
-#define LLDB_INTERPRETER_SCRIPTEDPROCESSINTERFACE_H
+#ifndef LLDB_INTERPRETER_SCRIPTED_PROCESS_INTERFACE_H
+#define LLDB_INTERPRETER_SCRIPTED_PROCESS_INTERFACE_H
----------------
I think the LLVM convention is to reserve underscores for the `/` in the file path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158833/new/

https://reviews.llvm.org/D158833



More information about the lldb-commits mailing list