[Lldb-commits] [lldb] 6bdf485 - [lldb] Re-enable TestVSCode_launch on Darwin

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 25 13:52:50 PDT 2023


Author: Jonas Devlieghere
Date: 2023-08-25T13:52:45-07:00
New Revision: 6bdf485887e5a2d613c3bf23ce96c216a086dfca

URL: https://github.com/llvm/llvm-project/commit/6bdf485887e5a2d613c3bf23ce96c216a086dfca
DIFF: https://github.com/llvm/llvm-project/commit/6bdf485887e5a2d613c3bf23ce96c216a086dfca.diff

LOG: [lldb] Re-enable TestVSCode_launch on Darwin

The test was disabled because it was supposedly flakey. I'm not able to
reproduce any flakiness. I ran the test in a look with different levels
of parallelization and load. Re-enabling the test and monitoring the
Darwin bots.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
index f6916964355df3..733c461305178d 100644
--- a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
+++ b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
@@ -14,7 +14,6 @@
 
 class TestVSCode_launch(lldbvscode_testcase.VSCodeTestCaseBase):
     @skipIfWindows
-    @skipIfDarwin  # Flaky
     @skipIfRemote
     def test_default(self):
         """
@@ -423,10 +422,10 @@ def test_extra_launch_commands(self):
 
     @skipIfWindows
     @skipIfNetBSD  # Hangs on NetBSD as well
-    @skipIfDarwin
     @skipIf(
-        archs=["arm", "aarch64"]
-    )  # Example of a flaky run http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5540/steps/test/logs/stdio
+        archs=["arm", "aarch64"],
+        oslist=["linux"]
+    )
     def test_terminate_commands(self):
         """
         Tests that the "terminateCommands", that can be passed during


        


More information about the lldb-commits mailing list