[Lldb-commits] [lldb] 1034688 - [lldb] Re-enable TestVSCode_disconnect on Darwin

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2023-08-25T11:02:38-07:00
New Revision: 1034688d58783779168d59b47d2b3e897ad869c6

URL: https://github.com/llvm/llvm-project/commit/1034688d58783779168d59b47d2b3e897ad869c6
DIFF: https://github.com/llvm/llvm-project/commit/1034688d58783779168d59b47d2b3e897ad869c6.diff

LOG: [lldb] Re-enable TestVSCode_disconnect on Darwin

The test was disabled because it failed on the sanitized bot. I'm not
able to reproduce that locally. The test uses timeouts which could
explain why it was failing in the past.

Let's re-enable it and see what happens. If it fails again on
GreenDragon, rather than disabling it on Darwin altogether, we should
either increase the timeouts or skip it when run under ASan.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py b/lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py
index c90293069e3e98..bc7b74e5039b47 100644
--- a/lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py
+++ b/lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py
@@ -23,7 +23,6 @@ def disconnect_and_assert_no_output_printed(self):
         output = self.get_stdout()
         self.assertTrue(output is None or len(output) == 0)
 
-    @skipIfDarwin
     @skipIfWindows
     @skipIfRemote
     def test_launch(self):
@@ -46,7 +45,6 @@ def test_launch(self):
         time.sleep(1)
         self.assertFalse(os.path.exists(program + ".side_effect"))
 
-    @skipIfDarwin
     @skipIfWindows
     @skipIfRemote
     @expectedFailureNetBSD