[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 23 19:59:02 PDT 2023


clayborg updated this revision to Diff 552966.
clayborg added a comment.

Address review comments:

- Added documentation in DYLDRendezvous.h to explain how things are supposed to work
- Updated the documentation in DYLDRendezvous::GetAction() to explain why we need to work around seeing two consecutive eAdd states
- Greatly simplify the test that was added per suggestions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158583/new/

https://reviews.llvm.org/D158583

Files:
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.h
  lldb/test/API/functionalities/dyld-multiple-rdebug/Makefile
  lldb/test/API/functionalities/dyld-multiple-rdebug/TestDyldWithMultupleRDebug.py
  lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.cpp
  lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.h
  lldb/test/API/functionalities/dyld-multiple-rdebug/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158583.552966.patch
Type: text/x-patch
Size: 17079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230824/603d44fa/attachment-0001.bin>


More information about the lldb-commits mailing list