[Lldb-commits] [lldb] a3e6ac1 - [lldb/test] Fix TestSaveCrashlog.py following changes in eef5eadbe617

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 18 15:30:07 PDT 2023


Author: Med Ismail Bennani
Date: 2023-08-18T23:29:40+01:00
New Revision: a3e6ac16ffc32e794da3f60150e903027f279f27

URL: https://github.com/llvm/llvm-project/commit/a3e6ac16ffc32e794da3f60150e903027f279f27
DIFF: https://github.com/llvm/llvm-project/commit/a3e6ac16ffc32e794da3f60150e903027f279f27.diff

LOG: [lldb/test] Fix TestSaveCrashlog.py following changes in eef5eadbe617

This patch fixes TestSaveCrashlog.py failure introduces by eef5eadbe617,
which restricts the number of positional argument for the output file to 1.

I expected to get the output file but `argparse` puts the object in a
list (even by constrained to a singled positional argument).

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>

Added: 
    

Modified: 
    lldb/examples/python/crashlog.py

Removed: 
    


################################################################################
diff  --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 5f6b84ff795eb8..efef43045f9c60 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -1274,7 +1274,7 @@ def save_crashlog(debugger, command, exe_ctx, result, dict):
         return
     target = exe_ctx.target
     if target:
-        out_file = options.output
+        out_file = options.output[0]
         identifier = target.executable.basename
         process = exe_ctx.process
         if process:


        


More information about the lldb-commits mailing list