[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

[David Spickett via Phabricator via lldb-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737
+  if (!dwo_file.IsRelative()) {
+    found = FileSystem::Instance().Exists(dwo_file);
+  } else {
----------------
DavidSpickett wrote:
> clayborg wrote:
> > Maybe we can also check the debug info search paths to see if they contain just the basename in case someone sends you a binary and any needed .dwo files?
> > 
> > So if we have a DWO path of "/users/someone/build/foo.dwo", we would check each of the debug info search paths for:
> > ```
> > path + dwo_file.GetFilename()
> > ```
> > This would allow someone to send a binary to someone else and allow them to load it up.
> > 
> > But any such search might belong down below this entire if/else statement when the file isn't found:
> > 
> > ```
> > if (!found) {
> >   // Search for debug info path + basename...
> > }
> > ```
> Good idea, I'll write a test for that scenario and see if it makes sense here or in a follow up.
https://reviews.llvm.org/D158182


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157609/new/

https://reviews.llvm.org/D157609