[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda updated this revision to Diff 550917.
jasonmolenda added a comment.

Update patch to remove the HasValue/IsValue and Clear methods from AddressableBits.  Change methods that may fill in an AddressableBits object with values to return an AddressableBits object unconditionally.  Change `AddressableBits::SetProcessMasks` so it can be called unconditionally, and it only sets mask values in Process if values were set.

I wanted to allow for someone to create an AddressableBits object with only the high memory addressing bits specified (for instance) and the low memory address mask will not be changed.  I updated `AddressableBits::SetProcessMasks` to use the current Process mask values if it doesn't have a value specified.  This will be more important when I add the SB API to SBProcess to set address masks in https://reviews.llvm.org/D155905 I expect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155905/new/

https://reviews.llvm.org/D155905

Files:
  lldb/docs/lldb-gdb-remote.txt
  lldb/include/lldb/Symbol/ObjectFile.h
  lldb/include/lldb/Utility/AddressableBits.h
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
  lldb/source/Utility/AddressableBits.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155905.550917.patch
Type: text/x-patch
Size: 13582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230816/788da578/attachment-0001.bin>