[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/include/lldb/Core/Module.h:126
   Module(
-      const FileSpec &file_spec, const ArchSpec &arch,
-      const ConstString *object_name = nullptr,
+      const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,
       lldb::offset_t object_offset = 0,
----------------
fdeazeve wrote:
> Out of curiosity, what was the rationale for removing the default parameter here?
I didn't really even think about it, I probably should have just done `ConstString object_name = ConstString()` or something.


================
Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:806
+                                                   target.GetArchitecture(),
+                                                   ConstString());
           }
----------------
mib wrote:
> Can this be `{}` ?
Yes, although I'll probably make the default value of the parameter be an empty ConstString instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158043/new/

https://reviews.llvm.org/D158043