[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 15 16:28:42 PDT 2023


JDevlieghere added inline comments.


================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:780
 
   PThreadMutex::Locker locker(m_mutex);
   if (m_rx_packets.empty()) {
----------------
This is an RAII object, right? Can we just block scope it? Right now it looks like we might not unlock if we return early on line 787. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158035/new/

https://reviews.llvm.org/D158035



More information about the lldb-commits mailing list