[Lldb-commits] [lldb] 92d7254 - [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

[Michael Buch via lldb-commits]

Author: Michael Buch
Date: 2023-08-15T23:09:59+01:00
New Revision: 92d7254a989d106ba63e64d315dbb9397c275671

URL: https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671
DIFF: https://github.com/llvm/llvm-project/commit/92d7254a989d106ba63e64d315dbb9397c275671.diff

LOG: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

The usage of this variable was removed in `4f14c17df70916913d71914343dd4f6c709e218d`.

This is no longer used inside this file. Since the call to
`GetPersistentExpressionStateForLanguage` has side-effects I marked this
NFCI. But there is no good reason we need this here.

Differential Revision: https://reviews.llvm.org/D157992

Added: 
    

Modified: 
    lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp b/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
index e780cd8285c455..314a4aca8d2663 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
@@ -54,18 +54,6 @@ class BlockPointerSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
     if (!clang_ast_context)
       return;
 
-    std::shared_ptr<ClangASTImporter> clang_ast_importer;
-    auto *state = target_sp->GetPersistentExpressionStateForLanguage(
-        lldb::eLanguageTypeC_plus_plus);
-    if (state) {
-      auto *persistent_vars = llvm::cast<ClangPersistentVariables>(state);
-      clang_ast_importer = persistent_vars->GetClangASTImporter();
-    }
-
-    if (!clang_ast_importer) {
-      return;
-    }
-
     const char *const isa_name("__isa");
     const CompilerType isa_type =
         clang_ast_context->GetBasicType(lldb::eBasicTypeObjCClass);