[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 15 15:05:51 PDT 2023


jingham updated this revision to Diff 550495.
jingham added a comment.

Respond to review comments.

In the course of implementing Alex's suggestion to add a filter to GetListeners, I noticed that there we were being lax in our dealing with removed listeners.  RemoveListener didn't actually do that, it just removed the event bits, and the next pass through GetListeners would actually clear out the entry.

Fixing that required a few other little fixes to get this working again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157556/new/

https://reviews.llvm.org/D157556

Files:
  lldb/include/lldb/Target/Process.h
  lldb/include/lldb/Utility/Broadcaster.h
  lldb/include/lldb/Utility/Event.h
  lldb/source/Target/Process.cpp
  lldb/source/Utility/Broadcaster.cpp
  lldb/source/Utility/Event.cpp
  lldb/source/Utility/Listener.cpp
  lldb/test/API/api/listeners/TestListener.py
  lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py
  lldb/test/API/python_api/event/TestEvents.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157556.550495.patch
Type: text/x-patch
Size: 28770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230815/93fdff13/attachment-0001.bin>


More information about the lldb-commits mailing list