[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:800-806
+        thread = self.crashlog.Thread(
+            len(self.crashlog.threads), True, self.crashlog.process_arch
+        )
+        thread.queue = "Application Specific Backtrace"
+        for backtrace in json_app_specific_bts:
             if self.parse_asi_backtrace(thread, backtrace):
                 self.crashlog.threads.append(thread)
----------------
bulbazord wrote:
> Conceptually it looks like this is creating a new thread and adding it over and over to the crashlog list of threads? How does this work?
Indeed, this is bogus :p Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157851/new/

https://reviews.llvm.org/D157851