[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Mon Aug 14 13:53:33 PDT 2023

bulbazord added a comment.

In D157497#4586165 <https://reviews.llvm.org/D157497#4586165>, @MaskRay wrote:

> In D157497#4584621 <https://reviews.llvm.org/D157497#4584621>, @Pivnoy wrote:
>
>> This discussion was the main motivation for this change.
>> https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11
>> As a result, Triple should become a data class, and its dependencies such as Architecture, Operating System etc. represent in the form of interfaces that can be implemented for the necessary instances.
>
> FWIW I still don't see advantages by switching to the new `llvm::TripleUtils::isArch32Bit` style. How is it better than the current way?

+1
What advantages does this approach bring? I re-read the RFC in the discourse link you posted and I'm still not sure why this approach is desirable. Happy to discuss further either on this PR or in the discourse thread.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157497/new/

https://reviews.llvm.org/D157497