[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:125-126
 
-  lldb::addr_t GetAddressMask() override;
+  bool GetAddressMask(lldb::addr_t &lowmem_mask,
+                      lldb::addr_t &highmem_mask) override;
 
----------------
I would prefer this to return a struct with the two masks, possibly living in Utility. The struct would centralize default values, which values are meaningful, etc and could be stored as a member in `GDBRemoteCommunicationClient`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157667/new/

https://reviews.llvm.org/D157667