[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:500-503
+  /// /param[out] lowmem_mask
+  ///     Address mask to be used for low memory addresses.
+  ///
+  /// /param[out] highmem_mask
----------------
`/param` -> `\param`


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:917-918
+      lldb::addr_t hi_address_mask = ~((1ULL << high_mem_addressable_bits) - 1);
+      SetCodeAddressMask(hi_address_mask);
+      SetDataAddressMask(hi_address_mask);
+    }
----------------
These should be `SetHighmemCodeAddressMask` and `SetHighmemDataAddressMask` right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157667/new/

https://reviews.llvm.org/D157667