[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 9 14:41:01 PDT 2023


clayborg added inline comments.


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:699-703
+  // `function_name` can be a nullptr, which throws an error when assigned to an
+  // `std::string`.
+  const char *function_name = frame.GetDisplayFunctionName();
+  std::string frame_name =
+      function_name == nullptr ? std::string() : function_name;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156970/new/

https://reviews.llvm.org/D156970



More information about the lldb-commits mailing list