[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Host/StreamFile.h:12
 
 #include "lldb/Host/File.h"
 #include "lldb/Utility/Stream.h"
----------------
bulbazord wrote:
> mib wrote:
> > bulbazord wrote:
> > > mib wrote:
> > > > Do we really need this header ? We could forward declare FileSP do avoid having to include it here 
> > > We're actually using it in this header (look at `GetFile()`).
> > There is already a `GetFileSP` we could use that instead and remove `GetFile`
> Yeah, that would be a good idea. Especially since `GetFile()` itself doesn't check the validity of the `FileSP` it has anyway... And it doesn't seem like there's an obvious way to check for validity before calling `GetFile()`. Is it ok if I do that in a follow-up? I don't want a revert to move the file back to `lldbCore` in case something goes wrong.
Sure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157460/new/

https://reviews.llvm.org/D157460