[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 9 11:17:34 PDT 2023


mib added inline comments.


================
Comment at: lldb/include/lldb/Host/StreamFile.h:12
 
 #include "lldb/Host/File.h"
 #include "lldb/Utility/Stream.h"
----------------
bulbazord wrote:
> mib wrote:
> > Do we really need this header ? We could forward declare FileSP do avoid having to include it here 
> We're actually using it in this header (look at `GetFile()`).
There is already a `GetFileSP` we could use that instead and remove `GetFile`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157460/new/

https://reviews.llvm.org/D157460



More information about the lldb-commits mailing list