[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

Patch looks good to me, one small suggestion about naming.



================
Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89
   void CreateMemoryRegions();
-  void LoadBinariesViaMetadata();
+  bool LoadBinariesViaMetadata();
   void LoadBinariesViaExhaustiveSearch();
----------------
Since `LoadBinariesViaMetadata` can fail and we now care about the return value, what do you think about the name `TryLoadBinariesViaMetadata`? I think a name that indicates that it may fail to actually load would make it easier to read at a glance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157168/new/

https://reviews.llvm.org/D157168