[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

[David Spickett via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGaa2784876a24: [lldb] Fix typo in comments and in test (authored by Eymay, committed by DavidSpickett).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157214/new/

https://reviews.llvm.org/D157214

Files:
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
  lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
  lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py


Index: lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
===================================================================
--- lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
+++ lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
@@ -91,7 +91,7 @@
     def test_uuid_modules_elf_build_id_16(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is valid and is 16 bytes long.
+        and contains an ELF build ID whose value is valid and is 16 bytes long.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-16.yaml")
         self.assertEqual(2, len(modules))
@@ -101,7 +101,7 @@
     def test_uuid_modules_elf_build_id_20(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is valid and is 20 bytes long.
+        and contains an ELF build ID whose value is valid and is 20 bytes long.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-20.yaml")
         self.assertEqual(2, len(modules))
@@ -115,7 +115,7 @@
     def test_uuid_modules_elf_build_id_zero(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is all zero.
+        and contains an ELF build ID whose value is all zero.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-zero.yaml")
         self.assertEqual(2, len(modules))
@@ -125,7 +125,7 @@
     def test_uuid_modules_elf_build_id_same(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is
-        valid, and contains a ELF build ID whose value is the same. There
+        valid, and contains an ELF build ID whose value is the same. There
         is an assert in the PlaceholderObjectFile that was firing when we
         encountered this which was crashing the process that was checking
         if PlaceholderObjectFile.m_base was the same as the address this
Index: lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
===================================================================
--- lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
+++ lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
@@ -348,7 +348,7 @@
 
     @skipIfXmlSupportMissing
     @skipIfRemote
-    def test_flags_requried_attributes(self):
+    def test_flags_required_attributes(self):
         # flags must have an id and size so the flags with "C" is the only valid one
         # here.
         self.setup_register_test(
Index: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
===================================================================
--- lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -53,7 +53,7 @@
                                                bool can_connect) {
   lldb::ProcessSP process_sp;
   if (crash_file && !can_connect) {
-    // Read enough data for a ELF32 header or ELF64 header Note: Here we care
+    // Read enough data for an ELF32 header or ELF64 header Note: Here we care
     // about e_type field only, so it is safe to ignore possible presence of
     // the header extension.
     const size_t header_size = sizeof(llvm::ELF::Elf64_Ehdr);
Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -2755,8 +2755,8 @@
               assert(vm_nlist_bytes_read == nlist_byte_size * nlistCount);
 
               // We don't know the size of the string table. It's cheaper
-              // to map the whol VM region than to determine the size by
-              // parsing all teh nlist entries.
+              // to map the whole VM region than to determine the size by
+              // parsing all the nlist entries.
               vm_address_t string_address = (vm_address_t)stringTable;
               vm_size_t region_size;
               mach_msg_type_number_t info_count = VM_REGION_BASIC_INFO_COUNT_64;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157214.547753.patch
Type: text/x-patch
Size: 4407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230807/eeb67196/attachment.bin>