[Lldb-commits] [lldb] aa27848 - [lldb] Fix typo in comments and in test

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 7 05:57:03 PDT 2023


Author: Eymen Ünay
Date: 2023-08-07T12:56:55Z
New Revision: aa2784876a245f10811f65eb748c43574c17a173

URL: https://github.com/llvm/llvm-project/commit/aa2784876a245f10811f65eb748c43574c17a173
DIFF: https://github.com/llvm/llvm-project/commit/aa2784876a245f10811f65eb748c43574c17a173.diff

LOG: [lldb] Fix typo in comments and in test

Reviewed By: DavidSpickett

Differential Revision: https://reviews.llvm.org/D157214

Added: 
    

Modified: 
    lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
    lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
    lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index 2d706835fd2400..56e1726aa5710c 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -2755,8 +2755,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
               assert(vm_nlist_bytes_read == nlist_byte_size * nlistCount);
 
               // We don't know the size of the string table. It's cheaper
-              // to map the whol VM region than to determine the size by
-              // parsing all teh nlist entries.
+              // to map the whole VM region than to determine the size by
+              // parsing all the nlist entries.
               vm_address_t string_address = (vm_address_t)stringTable;
               vm_size_t region_size;
               mach_msg_type_number_t info_count = VM_REGION_BASIC_INFO_COUNT_64;

diff  --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
index bfb59eceb2d025..8ff4ae1e19c0f6 100644
--- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -53,7 +53,7 @@ lldb::ProcessSP ProcessElfCore::CreateInstance(lldb::TargetSP target_sp,
                                                bool can_connect) {
   lldb::ProcessSP process_sp;
   if (crash_file && !can_connect) {
-    // Read enough data for a ELF32 header or ELF64 header Note: Here we care
+    // Read enough data for an ELF32 header or ELF64 header Note: Here we care
     // about e_type field only, so it is safe to ignore possible presence of
     // the header extension.
     const size_t header_size = sizeof(llvm::ELF::Elf64_Ehdr);

diff  --git a/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py b/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
index c2b6da11630f37..9e553c57f39cb7 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterFlags.py
@@ -348,7 +348,7 @@ def test_flags_unknown_attribute(self):
 
     @skipIfXmlSupportMissing
     @skipIfRemote
-    def test_flags_requried_attributes(self):
+    def test_flags_required_attributes(self):
         # flags must have an id and size so the flags with "C" is the only valid one
         # here.
         self.setup_register_test(

diff  --git a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
index bca1e5a8403681..2a3d291086b662 100644
--- a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
+++ b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
@@ -91,7 +91,7 @@ def test_uuid_modules_with_age(self):
     def test_uuid_modules_elf_build_id_16(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is valid and is 16 bytes long.
+        and contains an ELF build ID whose value is valid and is 16 bytes long.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-16.yaml")
         self.assertEqual(2, len(modules))
@@ -101,7 +101,7 @@ def test_uuid_modules_elf_build_id_16(self):
     def test_uuid_modules_elf_build_id_20(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is valid and is 20 bytes long.
+        and contains an ELF build ID whose value is valid and is 20 bytes long.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-20.yaml")
         self.assertEqual(2, len(modules))
@@ -115,7 +115,7 @@ def test_uuid_modules_elf_build_id_20(self):
     def test_uuid_modules_elf_build_id_zero(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
-        and contains a ELF build ID whose value is all zero.
+        and contains an ELF build ID whose value is all zero.
         """
         modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-zero.yaml")
         self.assertEqual(2, len(modules))
@@ -125,7 +125,7 @@ def test_uuid_modules_elf_build_id_zero(self):
     def test_uuid_modules_elf_build_id_same(self):
         """
         Test multiple modules having a MINIDUMP_MODULE.CvRecord that is
-        valid, and contains a ELF build ID whose value is the same. There
+        valid, and contains an ELF build ID whose value is the same. There
         is an assert in the PlaceholderObjectFile that was firing when we
         encountered this which was crashing the process that was checking
         if PlaceholderObjectFile.m_base was the same as the address this


        


More information about the lldb-commits mailing list