[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sat Aug 5 11:54:20 PDT 2023
JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5454-5456
+ if (log)
+ log->Printf("LC_NOTE 'kern ver str' found with text '%s'",
+ result.c_str());
----------------
Please use `LLDB_LOG(F)`:
```
LLDB_LOGF(log, "LC_NOTE 'kern ver str' found with text '%s'", result.c_str());
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157160/new/
https://reviews.llvm.org/D157160
More information about the lldb-commits
mailing list