[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 4 14:01:14 PDT 2023


mib created this revision.
mib added reviewers: JDevlieghere, bulbazord.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.

This patch skips images with an empty path or a 0 UUID from loading as a
SymbolFileJSON.

rdar://112107986

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157137

Files:
  lldb/examples/python/symbolication.py


Index: lldb/examples/python/symbolication.py
===================================================================
--- lldb/examples/python/symbolication.py
+++ lldb/examples/python/symbolication.py
@@ -411,6 +411,11 @@
                     )
             if not self.module and self.section_infos:
                 name = os.path.basename(self.path)
+                if not name:
+                    if self.uuid == uuid.UUID(int=0):
+                        return None
+                    else:
+                        return "error: invalid image path with valid UUID (%s) " % uuid_str
                 if obj_dir and os.path.isdir(obj_dir):
                     data = {
                         "triple": target.triple,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157137.547336.patch
Type: text/x-patch
Size: 727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230804/f229b682/attachment.bin>


More information about the lldb-commits mailing list