[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 4 11:55:15 PDT 2023


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM. If it's straightforward, I think would be nice to have a unit test with two threads modifying the same `OptionValue`. That way a TSan run would catch this issue. If that's more work than expected then this is fine as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157041/new/

https://reviews.llvm.org/D157041



More information about the lldb-commits mailing list