[Lldb-commits] [lldb] e383776 - [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

J. Ryan Stinnett via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 4 03:25:27 PDT 2023


Author: J. Ryan Stinnett
Date: 2023-08-04T11:24:36+01:00
New Revision: e383776ad0fbbe3d3704558fc8852c826680ce8f

URL: https://github.com/llvm/llvm-project/commit/e383776ad0fbbe3d3704558fc8852c826680ce8f
DIFF: https://github.com/llvm/llvm-project/commit/e383776ad0fbbe3d3704558fc8852c826680ce8f.diff

LOG: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

The `LLDB_LINKER_SUPPORTS_GROUPS` CMake variable was added back in 2019 as part
of https://reviews.llvm.org/D71306, but it appears to have been unused even
then. This removes the unused variable.

Differential Revision: https://reviews.llvm.org/D156997

Added: 
    

Modified: 
    lldb/cmake/modules/LLDBConfig.cmake

Removed: 
    


################################################################################
diff  --git a/lldb/cmake/modules/LLDBConfig.cmake b/lldb/cmake/modules/LLDBConfig.cmake
index ce90ecabc6a5a5..ca64ba798eda2d 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -17,12 +17,6 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
     "`CMakeFiles'. Please delete them.")
 endif()
 
-set(LLDB_LINKER_SUPPORTS_GROUPS OFF)
-if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
-  # The Darwin linker doesn't understand --start-group/--end-group.
-  set(LLDB_LINKER_SUPPORTS_GROUPS ON)
-endif()
-
 macro(add_optional_dependency variable description package found)
   cmake_parse_arguments(ARG
     "QUIET"


        


More information about the lldb-commits mailing list