[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 3 16:40:05 PDT 2023


jingham marked an inline comment as done.
jingham added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:303
+            return false;
+          count = llvm::popcount(bitfield);
+          break;
----------------
bulbazord wrote:
> This clobbers the previously set `count` on line 294. What of that `count`?
Oh, that's me saying it was bad to use a variable called `count` when it should be `bitfield`, adding the new one and then forgetting to delete the count version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157022/new/

https://reviews.llvm.org/D157022



More information about the lldb-commits mailing list