[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 3 09:39:35 PDT 2023


DavidSpickett accepted this revision.
DavidSpickett added a comment.

I think this could be tested with an lldb-server test, but it would likely go in `lldb/test/API/tools/lldb-server/TestGdbRemotePlatformFile.py` which has every test marked as skipped on Windows. For reasons lost to time.

If you feel like trying to re-enable them, great, otherwise I'm ok for such a simple fix to go in as is. Thanks again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156817/new/

https://reviews.llvm.org/D156817



More information about the lldb-commits mailing list