[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

Thu Aug 3 08:22:14 PDT 2023

mgorny added subscribers: paperchalice, tstellar, mgorny.
mgorny added a comment.

I'm not sure if it was really intended but the new API is kinda horrible, at least for us in Gentoo.

Our install prefix is `/usr/lib/llvm/NN`, whereas clang resource dir is `/usr/lib/clang/NN`.

If I don't override `CLANG_RESOURCE_DIR`, it infers the wrong directory: `/usr/lib/llvm/18/lib64/cmake/clang/../../..//lib64/clang/18`.

To get the correct directory, I need to pass `-DCLANG_RESOURCE_DIR="../../../clang/${LLVM_MAJOR}"` which is absolutely counterintuitive (the path gets appended to `/usr/lib/llvm/18/lib64/cmake/clang/../../../bin`).

Not saying it's not workable but I'd hardly call that an improvement over the previous API.

CC @tstellar, @paperchalice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156270/new/

https://reviews.llvm.org/D156270