[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

[Fangrui Song via Phabricator via lldb-commits]

MaskRay added inline comments.


================
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:23
+
+class TestMCDisasmInstanceRISCV : public testing::Test {
+public:
----------------
Place all classes and test methods in an anonymous namespace.


================
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:64
+  // and we should skip these tests without marking anything as failing.
+  if (disass_sp) {
+    const InstructionList inst_list (disass_sp->GetInstructionList());
----------------
Early return


================
Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:76
+      return false;
+    if (Info->get(Inst.getOpcode()).hasDefOfPhysReg(Inst, PC, MCRI))
+      return true;
----------------
`return Info->get(Inst.getOpcode()).hasDefOfPhysReg(Inst, PC, MCRI)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156086/new/

https://reviews.llvm.org/D156086